Use current-run certificate paths in workflows, add mixed-mode validation, and publish SIR v2.2 docs - #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.github/workflows/audit-and-sign.yml,.github/workflows/r1-cli-acceptance.yml, and paired-benchmark workflow steps to captureOUTPUT_AUDIT_JSON/GATED_RUN_IDfrom run output, expose them as step outputs, and then use those outputs (audit_json,gated_audit_json) for validation, verification, archival, docs publication, artifact uploads, and commit staging instead of hard-codedproofs/latest-audit.jsonpaths.generate_certificate.pyorsir benchmark rundo not emit expected outputs, and includedproofs/local-audit.*in artifacts to preserve non-canonical run certificates.src/sir_firewall/core.pyintroducedMIXED_MODE_REASON, a new_reject_mixed_mode_validationhelper, a dedicated_RULE_GROUPSentry for mixed-mode validation, and switched the mixed-mode code path to emitmultiple_ingress_modes_not_allowedwith the newmixed_mode_validation_failedreason, while improving rule group lookup in_build_block.red_team_suite.pyto stop supplyingpack_hashfrom the harness (pack hash remains a backlog item), and updated unit tests and expected outputs accordingly.README.mdto SIR v2.2, addeddocs/backlog.md, addeddocs/evidence-perimeter.v4.md, and addeddocs/release-notes-2.2.mdchanges describing semantics and operator changes.Testing
pytest -q, including updated teststests/test_tool_result_ingress.pyandtests/test_pack_binding.py, and the test run completed successfully.tools/generate_certificate.pyandsir benchmark runsimulation paths to verify step-output parsing and error handling, which produced expected outputs and exit codes.audit_jsonwhen present, and are skipped cleanly when the run produced only a local non-canonical certificate.Codex Task